[ET-VK] Replace Uniform buffers with push constants for view op #7229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

facebook-github-bot merged 12 commits into gh/trivedivivek/24/base from gh/trivedivivek/24/head

Dec 13, 2024

Contributor

trivedivivek commented Dec 6, 2024 •

edited

Loading

Stack from ghstack (oldest at bottom):

This diff replaces uniform buffers with push constants for view op in the Vulkan backend of Executorch. The changes include updating the GLSL code to use push constants instead of uniform buffers and updating the C++ code to pass the sizes as push constants to the shader.

Differential Revision: D66733658


          [ET-VK] Replace Uniform buffers with push constants for view op

40fd574

This diff replaces uniform buffers with push constants for view op in the Vulkan backend of Executorch. The changes include updating the GLSL code to use push constants instead of uniform buffers and updating the C++ code to pass the sizes as push constants to the shader.

Differential Revision: [D66733658](https://our.internmc.facebook.com/intern/diff/D66733658/)

[ghstack-poisoned]

pytorch-bot bot commented Dec 6, 2024 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7229

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 04fc85f with merge base de74961 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot added the CLA Signed label

Contributor

facebook-github-bot commented Dec 6, 2024

This pull request was exported from Phabricator. Differential Revision: D66733658

facebook-github-bot added the fb-exported label

This was referenced Dec 6, 2024

[ET-VK] Store unique ptr to StagingBuffer and SymInt in Value instead of inlined object, to reduce Value struct size from 80 to 32 bytes. #7152

Merged

[ET-VK] Removing unnecessary and redundant members from StagingBuffer. #7220

Merged

[ET-VK] Adding function to set push constants in Command buffer. #7221

Merged

[ET-VK] Adding UniformData struct in vTensor class to store uniform data, which will be stored using shared ptr and can be shared with push constants. #7222

Merged

[ET-VK] Add PushConstantDataInfo and vector to hold push constants data in DispatchNode. #7223

Merged

[ET-VK] Adding convenience functions in Compute graph to get PushConstantDataInfo for various attributes of a tensor. #7224

Merged

[ET-VK] Replace Uniform buffers with push constants for binary op #7230

Merged

[ET-VK] Replace Uniform buffers with push constants for permute op #7231

Merged


          Update on "[ET-VK] Replace Uniform buffers with push constants for vi…

501484e

…ew op"

This diff replaces uniform buffers with push constants for view op in the Vulkan backend of Executorch. The changes include updating the GLSL code to use push constants instead of uniform buffers and updating the C++ code to pass the sizes as push constants to the shader.

Differential Revision: [D66733658](https://our.internmc.facebook.com/intern/diff/D66733658/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Dec 6, 2024

This pull request was exported from Phabricator. Differential Revision: D66733658

junpi3 approved these changes

View reviewed changes

SS-JIA added the topic: not user facing label

trivedivivek added the release notes: backends label


          Update on "[ET-VK] Replace Uniform buffers with push constants for vi…

5bc6d0c

…ew op"

This diff replaces uniform buffers with push constants for view op in the Vulkan backend of Executorch. The changes include updating the GLSL code to use push constants instead of uniform buffers and updating the C++ code to pass the sizes as push constants to the shader.

Differential Revision: [D66733658](https://our.internmc.facebook.com/intern/diff/D66733658/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Dec 6, 2024

This pull request was exported from Phabricator. Differential Revision: D66733658


          Update on "[ET-VK] Replace Uniform buffers with push constants for vi…

73cf011

…ew op"

This diff replaces uniform buffers with push constants for view op in the Vulkan backend of Executorch. The changes include updating the GLSL code to use push constants instead of uniform buffers and updating the C++ code to pass the sizes as push constants to the shader.

Differential Revision: [D66733658](https://our.internmc.facebook.com/intern/diff/D66733658/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Dec 9, 2024

This pull request was exported from Phabricator. Differential Revision: D66733658


          Update on "[ET-VK] Replace Uniform buffers with push constants for vi…

40330f4

…ew op"

This diff replaces uniform buffers with push constants for view op in the Vulkan backend of Executorch. The changes include updating the GLSL code to use push constants instead of uniform buffers and updating the C++ code to pass the sizes as push constants to the shader.

Differential Revision: [D66733658](https://our.internmc.facebook.com/intern/diff/D66733658/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Dec 9, 2024

This pull request was exported from Phabricator. Differential Revision: D66733658


          Update on "[ET-VK] Replace Uniform buffers with push constants for vi…

8d94305

…ew op"

This diff replaces uniform buffers with push constants for view op in the Vulkan backend of Executorch. The changes include updating the GLSL code to use push constants instead of uniform buffers and updating the C++ code to pass the sizes as push constants to the shader.

Differential Revision: [D66733658](https://our.internmc.facebook.com/intern/diff/D66733658/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Dec 10, 2024

This pull request was exported from Phabricator. Differential Revision: D66733658

trivedivivek mentioned this pull request

[ET-VK] Replace Uniform buffers with push constants for copy op #7267

Merged


          Update on "[ET-VK] Replace Uniform buffers with push constants for vi…

425989f

…ew op"

This diff replaces uniform buffers with push constants for view op in the Vulkan backend of Executorch. The changes include updating the GLSL code to use push constants instead of uniform buffers and updating the C++ code to pass the sizes as push constants to the shader.

Differential Revision: [D66733658](https://our.internmc.facebook.com/intern/diff/D66733658/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Dec 11, 2024

This pull request was exported from Phabricator. Differential Revision: D66733658


          Update on "[ET-VK] Replace Uniform buffers with push constants for vi…

9fde95a

…ew op"

This diff replaces uniform buffers with push constants for view op in the Vulkan backend of Executorch. The changes include updating the GLSL code to use push constants instead of uniform buffers and updating the C++ code to pass the sizes as push constants to the shader.

Differential Revision: [D66733658](https://our.internmc.facebook.com/intern/diff/D66733658/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Dec 11, 2024

This pull request was exported from Phabricator. Differential Revision: D66733658


          Update on "[ET-VK] Replace Uniform buffers with push constants for vi…

7e35fe6

…ew op"

This diff replaces uniform buffers with push constants for view op in the Vulkan backend of Executorch. The changes include updating the GLSL code to use push constants instead of uniform buffers and updating the C++ code to pass the sizes as push constants to the shader.

Differential Revision: [D66733658](https://our.internmc.facebook.com/intern/diff/D66733658/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Dec 12, 2024

This pull request was exported from Phabricator. Differential Revision: D66733658


          Update on "[ET-VK] Replace Uniform buffers with push constants for vi…

2dab102

…ew op"

This diff replaces uniform buffers with push constants for view op in the Vulkan backend of Executorch. The changes include updating the GLSL code to use push constants instead of uniform buffers and updating the C++ code to pass the sizes as push constants to the shader.

Differential Revision: [D66733658](https://our.internmc.facebook.com/intern/diff/D66733658/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Dec 12, 2024

This pull request was exported from Phabricator. Differential Revision: D66733658


          Update on "[ET-VK] Replace Uniform buffers with push constants for vi…

c0f8d11

…ew op"

This diff replaces uniform buffers with push constants for view op in the Vulkan backend of Executorch. The changes include updating the GLSL code to use push constants instead of uniform buffers and updating the C++ code to pass the sizes as push constants to the shader.

Differential Revision: [D66733658](https://our.internmc.facebook.com/intern/diff/D66733658/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Dec 12, 2024

This pull request was exported from Phabricator. Differential Revision: D66733658


          Update on "[ET-VK] Replace Uniform buffers with push constants for vi…

04fc85f

…ew op"

This diff replaces uniform buffers with push constants for view op in the Vulkan backend of Executorch. The changes include updating the GLSL code to use push constants instead of uniform buffers and updating the C++ code to pass the sizes as push constants to the shader.

Differential Revision: [D66733658](https://our.internmc.facebook.com/intern/diff/D66733658/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Dec 12, 2024

This pull request was exported from Phabricator. Differential Revision: D66733658

facebook-github-bot merged commit d8564c0 into gh/trivedivivek/24/base

46 checks passed

facebook-github-bot deleted the gh/trivedivivek/24/head branch

December 13, 2024 03:37

facebook-github-bot temporarily deployed to cherry-pick-bot

December 13, 2024 03:37

— with

GitHub Actions Inactive

pytorchbot mentioned this pull request

[ET-VK] Replace Uniform buffers with push constants for view op #7319

Merged

kirklandsign pushed a commit that referenced this pull request


          [ET-VK] Replace Uniform buffers with push constants for view op

46acc71

Pull Request resolved: #7229

This diff replaces uniform buffers with push constants for view op in the Vulkan backend of Executorch. The changes include updating the GLSL code to use push constants instead of uniform buffers and updating the C++ code to pass the sizes as push constants to the shader.
ghstack-source-id: 257899594
@exported-using-ghexport

Differential Revision: [D66733658](https://our.internmc.facebook.com/intern/diff/D66733658/)

---------

Co-authored-by: Vivek Trivedi <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported topic: not user facing